Skip to content

Change input prefix for cram tests#41

Open
ancavar wants to merge 1 commit into
PLTools:1.30from
ancavar:input-prefix-fix
Open

Change input prefix for cram tests#41
ancavar wants to merge 1 commit into
PLTools:1.30from
ancavar:input-prefix-fix

Conversation

@ancavar

@ancavar ancavar commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

(Related to #40, split up since it's a breaking change)

Also see

Lama/src/Driver.ml

Lines 24 to 26 in fa98c7d

Printf.printf " > ";
(* NOTE(Kakadu): This kind of ouput (leading >) will be in a conflict with dune's
integration tests machinery *)
.

@ProgMiner

Copy link
Copy Markdown

Aren't there should be also changed test outputs?

@ancavar

ancavar commented Jun 25, 2026

Copy link
Copy Markdown
Contributor Author

Aren't there should be also changed test outputs?

I think all current tests use -i mode for which it's already handled in Driver.ml

@ProgMiner

Copy link
Copy Markdown

Aren't there should be also changed test outputs?

I think all current tests use -i mode for which it's already handled in Driver.ml

Ok I see... f6277da. @Kakadu, when there was a Makefile, these tests was apply for all three modes and not only for intertpreter. Is this regression of tests intentional?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants