Skip to content

Talos#2928

Merged
sparrowDom merged 188 commits into
masterfrom
talos
Jun 17, 2026
Merged

Talos#2928
sparrowDom merged 188 commits into
masterfrom
talos

Conversation

@sparrowDom

Copy link
Copy Markdown
Member

Migrate actions to Talos

Code Change Checklist

To be completed before internal review begins:

  • The contract code is complete
  • Executable deployment file
  • Fork tests that test after the deployment file runs
  • Unit tests *if needed
  • The owner has done a full checklist review of the code + tests

Internal review:

  • Two approvals by internal reviewers

sparrowDom and others added 30 commits March 23, 2026 17:52
- Add TypeScript, ESLint TS, and Prettier TS support to contracts/
- Create action() registration pattern for hardhat tasks with Winston logging
- Convert 13 Defender actions to self-registering TS hardhat tasks
- Add Loki transport for centralized logging
- Add healthcheck task for validation
- Fix ssv-scanner dependency (bloxapp → ssvlabs)
- Fix @lodestar/types ESM compatibility via ts-node skipProject
sparrowDom and others added 19 commits May 27, 2026 00:59
Without this, the runner image ships /app/actions-catalog.json missing,
runner.ts falls back to actionsCatalog = {}, and Talos admin's
fetchRunnerEditableFlags() gets 404 on /actions/<task>/params for every
task, surfacing as "No editable flags are registered for this task" in
the action edit dialog (regardless of params actually defined on the
hardhat task).

Mirrors the dump step already in talos/docker/origin-dollar.Dockerfile
(used by docker-compose dev). The talos-owned Dockerfile is not the
one CI builds with — this workflow uses ./contracts/dockerfile-actions
— so the dump was silently absent in production. Self-contained
CommonJS script copied verbatim from talos/docker/dump-actions-catalog.cjs.
The old-org (412463071885) Talos stack is decommissioned. Drop the
dual-push to both accounts and the old-account creds/login steps; build
and push the runner image to the new account (114563866192) ECR only.
claimBribes pinned gasLimit: 20000000 on removeAllNFTIds, fetchNFTIds and claimBribes. The Base RPC endpoint rejects a 20M tx gas limit ("gas limit too high"; Base block limit is 400M, so it is the endpoint's per-tx cap), so the action aborted on its first call (removeAllNFTIds) and never claimed bribes.

Remove the explicit gasLimit so the nonce queue's estimate + 20% buffer sets it. On-chain estimates as operator 0x7392: removeAllNFTIds 28546, fetchNFTIds 29597 — ~700x under the rejected 20M and well within the cap.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@codecov

codecov Bot commented Jun 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 44.63%. Comparing base (6a40630) to head (64d4451).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2928   +/-   ##
=======================================
  Coverage   44.63%   44.63%           
=======================================
  Files         110      110           
  Lines        4920     4920           
  Branches     1362     1362           
=======================================
  Hits         2196     2196           
  Misses       2721     2721           
  Partials        3        3           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sparrowDom sparrowDom merged commit 43037de into master Jun 17, 2026
17 of 20 checks passed
@sparrowDom sparrowDom deleted the talos branch June 17, 2026 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants