Remove viewport focus check from MapView _process#673
Open
Catylist0 wants to merge 1 commit into
Open
Conversation
Stop clearing province hover based on window focus and input handling in _process; use mouse enter/exit notifications instead. Co-authored-by: Cursor <cursoragent@cursor.com>
wvpm
reviewed
May 20, 2026
| if _cardinal_movement_vector != Vector2.ZERO and get_window().gui_get_focus_owner() != null: | ||
| _cardinal_movement_vector = Vector2.ZERO | ||
|
|
||
| if _is_viewport_inactive(): |
Contributor
There was a problem hiding this comment.
Is this case handled via the NOTIFICATION_WM_MOUSE_EXIT?
The old code implies it wasn't.
Author
There was a problem hiding this comment.
It should be now, in the old code we weren't catching the on exit stuff iirc, it was just doing a check each tick. Not sure why it was like that, this system should be more correct(?)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
is_input_handled()check fromMapView._processthat was clearing province hover.NOTIFICATION_WM_MOUSE_ENTERandNOTIFICATION_WM_MOUSE_EXITinstead.Made with Cursor