Main thread pick up work#747
Closed
wvpm wants to merge 1 commit into
Closed
Conversation
wvpm
force-pushed
the
main_thread_pick_up_work
branch
from
e3de318 to
2121a03
Compare
Contributor
Author
|
performance gains were not enough to justify using the main thread. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on top of #741
The ThreadPool spins up several worker threads and waits for them to finish.
Instead of waiting, it can join them and also work.
This reduces the thread count by 1 and saves some waiting.