Skip to content

Add missing dependencies to IncludeCategories#745

Merged
Spartan322 merged 1 commit into
masterfrom
fix/clang-format-header-order
May 20, 2026
Merged

Add missing dependencies to IncludeCategories#745
Spartan322 merged 1 commit into
masterfrom
fix/clang-format-header-order

Conversation

@Spartan322
Copy link
Copy Markdown
Member

@Spartan322 Spartan322 commented May 20, 2026

Format potentially category-related header includes

@Spartan322 Spartan322 requested a review from a team as a code owner May 20, 2026 11:52
@Spartan322 Spartan322 added bug Something isn't working enhancement New feature or request topic:codestyle labels May 20, 2026
Comment thread src/openvic-simulation/console/ConsoleInstance.cpp Outdated
Comment thread src/openvic-simulation/core/memory/SmartPtr.hpp Outdated
Comment thread src/openvic-simulation/country/CountryInstance.cpp
Comment thread src/openvic-simulation/country/CountryInstance.hpp Outdated
Comment thread src/openvic-simulation/dataloader/Dataloader.cpp
Comment thread src/openvic-simulation/dataloader/NodeTools.cpp Outdated
Comment thread src/openvic-simulation/economy/production/ArtisanalProducer.cpp Outdated
Comment thread src/openvic-simulation/economy/production/ResourceGatheringOperation.cpp Outdated
Comment thread src/openvic-simulation/map/MapDefinition.cpp Outdated
Comment thread src/openvic-simulation/map/MapDefinition.cpp Outdated
Comment thread src/openvic-simulation/map/ProvinceDefinition.hpp Outdated
Comment thread src/openvic-simulation/military/Wargoal.cpp
Comment thread src/openvic-simulation/misc/GameAction.hpp Outdated
Comment thread src/openvic-simulation/pathfinding/AStarPathing.hpp
Comment thread src/openvic-simulation/pathfinding/PointMap.cpp Outdated
Comment thread src/openvic-simulation/pathfinding/PointMap.hpp Outdated
Comment thread src/openvic-simulation/scripts/Condition.cpp Outdated
Comment thread src/openvic-simulation/testing/Testing.hpp
Comment thread src/openvic-simulation/types/Colour.hpp Outdated
Comment thread src/openvic-simulation/types/Date.hpp
Comment thread src/openvic-simulation/types/Vector.hpp
@Spartan322 Spartan322 force-pushed the fix/clang-format-header-order branch from 860df43 to 4a15fd2 Compare May 20, 2026 12:16
Comment thread src/openvic-simulation/country/CountryInstance.cpp Outdated
@Spartan322 Spartan322 force-pushed the fix/clang-format-header-order branch from 4a15fd2 to da8cba9 Compare May 20, 2026 12:28
Comment thread src/openvic-simulation/population/Pop.hpp Outdated
Comment thread src/openvic-simulation/population/PopsAggregate.cpp
Comment thread src/openvic-simulation/population/PopsAggregate.hpp
Comment thread src/openvic-simulation/GameManager.hpp
Format potentially category-related header includes
Add SortIncludes format option
@Spartan322 Spartan322 force-pushed the fix/clang-format-header-order branch from da8cba9 to ed6c198 Compare May 20, 2026 13:34
Copy link
Copy Markdown
Contributor

@wvpm wvpm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR that focuses purely on include ordering.
Only the third party vs openvic lib order is an open question.

@Spartan322 Spartan322 merged commit 4f7789a into master May 20, 2026
16 checks passed
@Spartan322 Spartan322 deleted the fix/clang-format-header-order branch May 20, 2026 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request topic:codestyle

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants