fix(teldrive): avoid index out of range panic when listing an empty dir#2585
Open
SAY-5 wants to merge 1 commit into
Open
fix(teldrive): avoid index out of range panic when listing an empty dir#2585SAY-5 wants to merge 1 commit into
SAY-5 wants to merge 1 commit into
Conversation
Signed-off-by: Sai Asish Y <say.apm35@gmail.com>
jyxjjj
approved these changes
Jun 6, 2026
Member
jyxjjj
left a comment
jyxjjj
left a comment
There was a problem hiding this comment.
Thank you for your contribution.
This pull request has been approved. However, before it can be merged, please update the PR description to match our default template. Do not remove any existing content; only reorganize or supplement it as needed to fit the template.
Thank you.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary / 摘要
When a Teldrive folder is empty the API returns
totalPages: 0, soListsizedpagesDatato length 0 and then panicked onpagesData[0]. This made copying into an empty Teldrive directory (and listing one) crash withindex out of range [0] with length 0. Returning early for the no-pages case fixes it; added a regression test that drivesListagainst an empty-listing response.Related Issues / 关联 Issue
Closes #2538