Speed up jnlp launch by 58%#287
Conversation
Test Results 111 files ±0 214 suites ±0 6m 59s ⏱️ + 1m 12s Results for commit f6e8def. ± Comparison against base commit 8c1111b. This pull request removes 3 tests.♻️ This comment has been updated with latest results. |
tonygermano
left a comment
There was a problem hiding this comment.
Looks fine at a glance. I think the only thing we're really losing is the title and vendor information for the individual extensions.
Does this still allow launching from MCAL?
The JNLP data is not shown anywhere that I can find in any of the launchers I've tested. The vendor information still shows normally in Extensions.
It works fine, but MCAL is broken in main - I recommend we drop support entirely. |
Signed-off-by: Mitch Gaffigan <mitch.gaffigan@comcast.net>
Signed-off-by: Mitch Gaffigan <mitch.gaffigan@comcast.net>
Signed-off-by: Mitch Gaffigan <mitch.gaffigan@comcast.net>
77ad485 to
f6e8def
Compare
Speeds launch time by not requiring multiple round-trips for each plugin. Classpath with ballista remained identical. No obvious benefit to the historical design - presumed to be some Java Security Manager pipe dream.
Mildly related: #197