toolchain: drop legacy gcc 8.4 pin on 18 ARM platforms#2162
Open
widgetii wants to merge 1 commit into
Open
Conversation
Remove the explicit "# Legacy" three-line block (BR2_TOOLCHAIN_EXTERNAL_GCC_8=y +
BR2_GCC_VERSION_LEGACY=y) from all defconfigs that still carried it:
Goke (11): gk7102, gk7102s, gk7202v300_{lite,ultimate},
gk7205v200_{lite,original,ultimate}, gk7205v210_lite,
gk7205v300_{lite,ultimate}, gk7605v100_lite
Grainmedia (2): gm8135_lite, gm8136_lite
Novatek (2): nt98562_lite, nt98566_lite
Xiongmai (3): xm510_lite, xm530_lite, xm550_lite
Without an explicit pin these defconfigs fall through to
BR2_GCC_VERSION_13_X (Buildroot 2024.02.10 default per
general/package/gcc/Config.in.host), so the cross-toolchains rebuild
with gcc 13.3.0 instead of 8.4.0.
All 18 platforms are ARM (arm1176jzf_s through later Cortex-A cores)
and supported by gcc 13's musl/libsanitizer code paths — the recently
scoped libsanitizer-musl-compat patch (#2161) now applies as expected.
The legacy pin originated in #1726 ("Set legacy GCC version for Goke",
2023) but the rationale has dissolved as upstream gcc/musl/libsanitizer
caught up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Drop the explicit `# Legacy` block from 18 defconfigs:
```
Legacy
```
Without an explicit pin they fall through to `BR2_GCC_VERSION_13_X` (Buildroot 2024.02.10 default per `general/package/gcc/Config.in.host`), so cross-toolchains now build with gcc 13.3.0 instead of 8.4.0.
Platforms affected
All 18 are ARM (oldest core is arm1176jzf_s on the gk7102 family) — well within gcc 13's supported set.
Why now
The legacy pin originated in #1726 ("[no ci] Set legacy GCC version for Goke", 2023) and propagated. Upstream gcc, musl, and libsanitizer have since caught up:
Test plan
Out of scope
This PR does not bump kernel-headers selections (`BR2_TOOLCHAIN_EXTERNAL_HEADERS_3_*` for the Xiongmai 3.0/3.4 etc. stays as is) — those are independent of the host compiler version.