Skip to content

Add mypy to CI#105

Merged
hannahbaumann merged 15 commits into
mainfrom
add_mypy_ci
May 22, 2026
Merged

Add mypy to CI#105
hannahbaumann merged 15 commits into
mainfrom
add_mypy_ci

Conversation

@hannahbaumann
Copy link
Copy Markdown
Contributor

@hannahbaumann hannahbaumann commented May 22, 2026

No description provided.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 22, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.71%. Comparing base (af90067) to head (ff1cce9).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #105      +/-   ##
==========================================
+ Coverage   96.09%   96.71%   +0.62%     
==========================================
  Files           6        6              
  Lines         333      335       +2     
==========================================
+ Hits          320      324       +4     
+ Misses         13       11       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hannahbaumann hannahbaumann requested a review from atravitz May 22, 2026 15:02
atravitz
atravitz approved these changes May 22, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@atravitz atravitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a comment and notes to update the action versions - I'll approve now to keep you unblocked.

Comment thread .github/workflows/mypy.yaml Outdated
Comment thread .github/workflows/mypy.yaml Outdated
Comment thread src/openfe_analysis/rmsd.py
- Flattened 2D protein RMSD matrix (pairwise RMSD between frames)
"""
output = {
output: dict[str, list[Any]] = {
Copy link
Copy Markdown
Contributor

@atravitz atravitz May 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

non-blocking for this PR, but it would be helpful to be more strict about these types. I think they should all be np.float64?

Copy link
Copy Markdown
Contributor Author

@hannahbaumann hannahbaumann May 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried different things but mypy kept complaining, because some items are list[list[float]] and some list[float], so I went back to Any, I hope that's ok!

hannahbaumann and others added 4 commits May 22, 2026 18:16
@hannahbaumann @atravitz
Update .github/workflows/mypy.yaml
7254ef8 
Co-authored-by: Alyssa Travitz <31974495+atravitz@users.noreply.github.com>
@hannahbaumann @atravitz
Update .github/workflows/mypy.yaml
7da2782 
Co-authored-by: Alyssa Travitz <31974495+atravitz@users.noreply.github.com>
@hannahbaumann
Small fix
3aea3b8
@hannahbaumann
Merge branch 'add_mypy_ci' of https://github.com/OpenFreeEnergy/openf…
8825be8 
…e_analysis into add_mypy_ci
@hannahbaumann hannahbaumann linked an issue May 22, 2026 that may be closed by this pull request
Add mypy checks to CI #100
Closed
@hannahbaumann hannahbaumann merged commit 5241600 into main May 22, 2026
6 checks passed
@hannahbaumann hannahbaumann deleted the add_mypy_ci branch May 22, 2026 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@atravitz atravitz atravitz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add mypy checks to CI

2 participants

@hannahbaumann @atravitz