feat: forward state.webhookResponse on step:complete#1404
Merged
Conversation
Collaborator
|
Couple of notes from me:
|
Job code sets state.webhookResponse = { status, body }; the worker
forwards it on the step:complete payload as webhook_response.
The key is stripped from the dataclip (worker) and from the next
step's input state (runtime) so it cannot leak downstream.
d2c1d95 to
06221e0
Compare
josephjclark
approved these changes
May 13, 2026
Collaborator
josephjclark
left a comment
There was a problem hiding this comment.
Lovely and light and clean - nice work @doc-han
I'll release this now
doc-han
approved these changes
May 13, 2026
…hjclark:OpenFn/kit into 1399-webhook-reponse-step-complete
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short Description
Job code sets state.webhookResponse = { status, body }; the worker forwards it on the step:complete payload as webhook_response. The key is stripped from the dataclip (worker) and from the next step's input state (runtime) so it cannot leak downstream.
Fixes #1399
QA Notes
Can be tested via OpenFn/lightning#4666
AI Usage
Please disclose whether you've used AI anywhere in this PR (it's cool, we just
want to know!):
You can read more details in our
Responsible AI Policy