Skip to content

[codex] ci(android): approve release version bump PR#274

Merged
TobiasRoeddiger merged 1 commit into
mainfrom
codex/android-version-bump-approval
Jun 24, 2026
Merged

[codex] ci(android): approve release version bump PR#274
TobiasRoeddiger merged 1 commit into
mainfrom
codex/android-version-bump-approval

Conversation

@TobiasRoeddiger

Copy link
Copy Markdown
Member

Summary

  • Add an explicit gh pr review --approve step before auto-merging the production release version-bump PR.
  • Uses the GitHub Actions PR approval permission that is now enabled for this repository.

Why

The production Android deploy workflow successfully uploads to Google Play, then creates a version-bump PR, but auto-merge fails with:

GraphQL: At least 1 approving review is required by reviewers with write access. (mergePullRequest)

The workflow created the PR and immediately tried to merge it without submitting an approval.

Validation

  • git diff --check origin/main...HEAD -- .github/workflows/android_build_and_deploy.yaml
  • ruby -e "require 'yaml'; YAML.load_file('.github/workflows/android_build_and_deploy.yaml'); puts 'yaml ok'"

Notes

If branch protection still requires approval from someone other than the last pusher, this may still need a separate machine-user/App token or a bypass actor. This change addresses the currently observed missing-approval error.

@TobiasRoeddiger TobiasRoeddiger marked this pull request as ready for review June 24, 2026 09:43
@TobiasRoeddiger TobiasRoeddiger merged commit d168e3a into main Jun 24, 2026
6 of 8 checks passed
@TobiasRoeddiger TobiasRoeddiger deleted the codex/android-version-bump-approval branch June 24, 2026 09:44
@github-actions

github-actions Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

PR Build Artifacts

Full workflow run: https://github.com/OpenEarable/app/actions/runs/28089731590

@github-actions

Copy link
Copy Markdown
Contributor

Visit the preview URL for this PR (updated for commit 1a95989):

https://open-earable-web--pr274-codex-android-versio-6rl8grg6.web.app

(expires Wed, 22 Jul 2026 09:44:17 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c7397c11177c71d8d81172cea9365829823fb41c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant