Skip to content

Support new JWT token based auth (openEO API 1.3.0)#859

Open
niebl wants to merge 49 commits into
Open-EO:masterfrom
niebl:jwt
Open

Support new JWT token based auth (openEO API 1.3.0)#859
niebl wants to merge 49 commits into
Open-EO:masterfrom
niebl:jwt

Conversation

@niebl

@niebl niebl commented Feb 6, 2026

Copy link
Copy Markdown

#850

Includes:

  • checking conformance in connection.authenticate_basic() and connection.authenticate_oidc() and formatting the bearer tokens accordingly
  • a /conformance endpoint in DummyBackend and a has_conformance({url}) method in capabilities. So JWT bearer token conformance can be checked.

@niebl

niebl commented Feb 6, 2026

Copy link
Copy Markdown
Author

still WIP, as testing with JWT conformant backends is not yet implemented (manual tests have shown that there is still something going wrong though)

Comment thread openeo/rest/auth/auth.py Outdated
Comment thread openeo/rest/auth/auth.py Outdated
Comment thread openeo/rest/_testing.py Outdated
Comment thread openeo/rest/_testing.py Outdated
Comment thread openeo/rest/capabilities.py Outdated
Comment thread openeo/rest/capabilities.py Outdated
Comment thread openeo/rest/connection.py Outdated
Comment thread openeo/rest/connection.py Outdated
niebl and others added 6 commits February 10, 2026 09:20
Co-authored-by: Matthias Mohr <m.mohr@moregeo.it>
Co-authored-by: Matthias Mohr <m.mohr@moregeo.it>
Co-authored-by: Matthias Mohr <m.mohr@moregeo.it>
Comment thread tests/rest/test_connection.py Outdated
niebl and others added 2 commits February 10, 2026 13:16
Co-authored-by: Matthias Mohr <m.mohr@moregeo.it>
@soxofaan

soxofaan commented Mar 4, 2026

Copy link
Copy Markdown
Member

hmm, it seems this PR got in a bad state, making the signal/noise ratio bad for review. I see various changes in places that are unrelated to the feature to implement here (conversions.py, results.py, _version.py, metadata.py, test_s3sts.py, ...)

did you by any chance cherry-picked commits from master, instead of merging master?

@m-mohr m-mohr mentioned this pull request Mar 4, 2026
@m-mohr

m-mohr commented Mar 4, 2026

Copy link
Copy Markdown
Member

@soxofaan I did clean up a potentially failed merge, this should improve the situation.

Somehat related: We also have changes come in from the linter for some of those files each time we run the linter. It might be that master is not clean with regards to linting?! => #869

@soxofaan soxofaan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for delay, I finally found some time to give this another review

Comment thread openeo/rest/auth/auth.py Outdated
Comment thread openeo/rest/auth/testing.py Outdated
Comment thread openeo/rest/_testing.py
Comment thread openeo/rest/connection.py Outdated
Comment thread tests/rest/conftest.py Outdated
Comment thread tests/rest/test_connection.py
Comment thread tests/rest/test_connection.py Outdated
@soxofaan

Copy link
Copy Markdown
Member

and another thing: this deserves a mention in the changelog too

@niebl niebl force-pushed the jwt branch 2 times, most recently from 9e341cc to 8ed91bf Compare April 8, 2026 08:33
@niebl

niebl commented Apr 8, 2026

Copy link
Copy Markdown
Author

Thank you very much for the review. I am sorry for the delay. I will be able to work on that feedback now

Comment thread tests/rest/test_testing.py Outdated
@niebl

niebl commented Apr 9, 2026

Copy link
Copy Markdown
Author

@soxofaan thank you for the review. I was able to apply your suggestions and shrink the size of the PR a little. I am once again sorry for the delay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support new JWT token based auth from openEO API 1.3

3 participants