Verify compile/symbol claims before asserting them#36
Merged
Conversation
![exe-dev-github-integration[bot]](https://avatars.githubusercontent.com/in/3061187?s=60&v=4){kind=small}
A refactor that moved an import between files drew a confidently-wrong 'won't typecheck' finding: the reviewer inferred a missing symbol from the diff surface instead of opening the file that still imported it. Fold one general rule into the precision step (verify what you can check before flagging it) and let it open any file, not just changed ones.
Octember
force-pushed
the
reviewer-verify-gate
branch
from
3310193 to
55c173c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kills the highest-value false-positive class: confidently-wrong "won't compile / missing import / undefined symbol" findings.
The reviewer has read access to the checkout, but the spec treated verification as optional. On a refactor that moved an import from one file to another, it flagged a
conf 1"won't typecheck" bug — without opening the file that still imported the symbol on an unchanged line the diff never showed.This makes verification mandatory for that claim class:
conf 0.5; reserveconf 1for defects verified by reading.Spec-only change (
.review/REVIEW-PROMPT.md); no engine code touched.