Reverse showing progress logic#81
Open
schaefi wants to merge 1 commit into
Open
Conversation
So far the user had to pass %silent to the call to make the pilot stop showing progress information. The default behavior to show progress information caused a lot of confusion and breakage to script code calling an application as a flake. It is rather unexpected that such progress information is provided by default. This commit reverse the logic such that a user has to provide %progress to see the progress spinner while the pilot is working. This Fixes #80
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So far the user had to pass
%silentto the call to make the pilot stop showing progress information. The default behavior to show progress information caused a lot of confusion and breakage to script code calling an application as a flake. It is rather unexpected that such progress information is provided by default. This commit reverse the logic such that a user has to provide%progressto see the progress spinner while the pilot is working.This Fixes #80