Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion document_page_reference/models/document_page.py
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ def _check_reference_validity(self):
for rec in self:
if not rec.reference:
continue
regex = r"^[a-zA-Z_][a-zA-Z0-9_]*$"
regex = r"^[a-zA-Z_][a-zA-Z0-9_-]*$"
if not re.match(regex, rec.reference):
raise ValidationError(_("Reference is not valid"))
domain = [("reference", "=", rec.reference), ("id", "!=", rec.id)]
Expand Down
16 changes: 10 additions & 6 deletions document_page_tag/models/document_page_tag.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,14 @@ class DocumentPageTag(models.Model):
("unique_name", "unique(name)", "Tags must be unique"),
]

@api.model
def create(self, vals):
@api.model_create_multi
def create(self, vals_list):
"""Be nice when trying to create duplicates"""
existing = self.search([("name", "=ilike", vals["name"])], limit=1)
if existing:
return existing
return super().create(vals)
result = self.env['document.page.tag']
for vals in vals_list:
existing = self.search([("name", "=ilike", vals.get("name", ""))], limit=1)
if existing:
result |= existing
else:
result |= super(DocumentPageTag, self).create(vals)
return result
Loading