fix(export): prevent static render hangs#62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the
/exporthang portion of #49 and updates/feedbackto target the real Noumena collector route./exportto hang before writing a file or showing the export dialogcellAt)ExportDialogso/export <filename>does not import dialog/model UI modules/feedbacksubmission from the legacy/api/claude_cli_feedbackpath to/api/ncode_feedback/export <filename>, and feedback collector request shape/fail-closed behaviorBackend note: the matching internal
api/change exposes authenticatedPOST /api/ncode_feedbackand the legacyPOST /api/claude_cli_feedbackalias through APIFE and stores feedback in the existingncode_logsScribe category before returningfeedback_id.Validation
Focused #49 regressions:
/home/xjdr/.bun/bin/bun test \ src/utils/staticRender.test.tsx \ src/commands/export/export.test.tsx \ src/components/Feedback.submit.test.tsResult:
4 pass, 0 fail.Model-mock ordering regression slice:
/home/xjdr/.bun/bin/bun test \ src/tools/toolPromptRouting.test.ts \ src/commands/export/export.test.tsxResult:
7 pass, 0 fail.Contracts:
PATH="$HOME/.bun/bin:$PATH" timeout 120s /home/xjdr/.bun/bin/bun run test:contractsResult from previous revision of this PR:
242 pass, 0 fail. After the latest feedback-route correction, focused regressions above passed; full contracts should rerun in CI/package smoke.Package smoke:
PATH="$HOME/.bun/bin:$PATH" timeout 180s /home/xjdr/.bun/bin/bun run test:package-smokeResult from previous revision of this PR: passed. Security audit OK; native probe OK with documented
sharp-fallbackimage mode.Diff check:
Result from previous revision of this PR: passed.