[codex] Start Intrade websocket quotes from subscriptions#63
Merged
Conversation
59efddd to
f1e8b7d
Compare
563de04 to
cccc532
Compare
f1e8b7d to
93bb31d
Compare
cccc532 to
138c6ae
Compare
93bb31d to
4e7465a
Compare
24db0b0 to
1266c71
Compare
c2a807e to
1ba896b
Compare
1266c71 to
1741afe
Compare
1ba896b to
eb50611
Compare
1741afe to
7dccf20
Compare
eb50611 to
bf85e61
Compare
7dccf20 to
b4330b9
Compare
bf85e61 to
8016e40
Compare
b4330b9 to
3076fa0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
CONNECTED./bapihost/header setup./fxconnectstreams connect as soon as a public websocket subscription is added, while preserving reconnect behavior when auth host/proxy settings change.MarketDataSubscriptionManager, including rollback and shutdown cleanup.Why
Market-data-only use should not require the full trading authentication/connect lifecycle when the broker quote endpoints are public. The public subscription API now activates websocket quote sources directly after configuration.
Validation
cmake --build build-codex --target intrade_bar_api_response_test -j 4./build-codex/intrade_bar_api_response_test.exe --gtest_filter=IntradeBarApiResponses.BtcWebSocketSubscriptionRunsWithoutAccountConnection:IntradeBarApiResponses.FxWebSocketSubscriptionRunsWithoutAccountConnection:IntradeBarApiResponses.BtcWebSocketSubscriptionReportsStatusAndRoutesTick:IntradeBarApiResponses.FxWebSocketSubscriptionReceivesLocalTick./build-codex/intrade_bar_api_response_test.exeNotes