[codex] Use TimeShield for MT4 legacy timing#50
Merged
Conversation
Update the time-shield-cpp submodule to the MQL4 facade commit and replace the local MT4 legacy timing helper logic with calls through TimeShield.mqh.
Update the TimeShield submodule to the MQL4 class facade and replace legacy connector constant aliases with direct TimeShield constants in the MQL4 and MQL5 connector helpers.
Point the legacy MQL bridge integration at the TimeShield revision that exposes a single MQL4 TimeShield.mqh header.
Update the TimeShield submodule to the main-branch merge commit for NewYaroslav/time-shield-cpp#114.
Use the constants exported by TimeShield.mqh in the form accepted by the MQL4 compiler, avoiding unsupported class-qualified enum access.
Update the TimeShield submodule to the MQL MetaEditor fix branch and adjust the legacy connector MQL4/MQL5 code paths found by local MetaEditor compilation.
Update the legacy MQL4 connector to use TSHIELD-prefixed TimeShield constants and point the submodule at the matching dependency revision.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
external/time-shield-cppto the MQL MetaEditor follow-up from [codex] Restore MQL MetaEditor compilation time-shield-cpp#115.<TimeShield.mqh>.TSHIELD_constants.TimeShield.mqh) instead of shipping bothTimeShield.mqhandtime_shield.mqh.inttouintstep fields.Dependency
Depends on NewYaroslav/time-shield-cpp#115. PR #114 is already merged.
Validation
git diff --checkcmake --build build-codex --target legacy_trading_bridge_test --parallel./build-codex/legacy_trading_bridge_test.exeLegacyTradingConnector.mq4— 0 errors, 0 warnings.LegacyTradingConnector-ru.mq4— 0 errors, 0 warnings.time_shield.mqh:LegacyTradingConnector.mq5— 0 errors, 8 warnings.time_shield.mqh:LegacyTradingConnector-ru.mq5— 0 errors, 8 warnings.Notes
The remaining MT5 warnings are pre-existing conversion/import warnings; code generation succeeds.