ABF: raise a clear error on files with an invalid signature#1873
Merged
h-mayorquin merged 2 commits intoJul 13, 2026
Conversation
zm711
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A file whose header does not start with a valid ABF (Axon Binary Format) signature (
b"ABF "orb"ABF2") failed with a crypticTypeError: 'NoneType' object is not subscriptabledeep insideparse_header, becauseparse_axon_soupreturnedNonefor an unrecognized signature and the caller then indexed into it. This now raises a clearNeoReadWriteErrornaming the file and the unexpected signature, so a caller can tell a corrupt or unsupported file from an actual bug.I put the error in
parse_axon_soupat the point the invalid signature is detected rather than null-checking in the caller, because that is where the signature bytes are available for the message and it makes "an unparseable file always raises" a property of the parser itself. The fixtureunparseable_header.abf(a zeroed signature) covers it.