Skip to content

Refactor mesh pimpl #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Luochenghuang wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Refactor mesh pimpl #88

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ba1b826
Refactor mesh storage with PIMPL: opaque internal cache behind scheme…
Luochenghuang May 30, 2026
3bad339
Eliminate slist_unique VLA in intersect_line_with_prism
Luochenghuang May 29, 2026
842cf75
Merge branch 'NanoComp:master' into refactor-mesh-pimpl
Luochenghuang May 30, 2026
3499e01
Inline mesh-internal.h into geom.c so MPB-style cp builds still work
Luochenghuang Jun 1, 2026
62857bd
Treat geom-ctl-io.c as checked-in, not BUILT_SOURCES
Luochenghuang Jun 1, 2026
50e5498
Refresh ctlgeom-types.h and geom-ctl-io.c against current geom.scm
Luochenghuang Jun 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions utils/Makefile.am
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,12 @@ nodist_include_HEADERS = ctlgeom-types.h
lib_LTLIBRARIES = libctlgeom.la
noinst_PROGRAMS = geomtst

EXTRA_DIST = gen-ctl-io.in README geom.scm geom-ctl-io-defaults.c nlopt.c
# geom-ctl-io.c is checked in and hand-maintained — it carries PIMPL
# lifecycle hooks (extern declarations + calls to mesh_init_internal and
# mesh_internal_free in mesh_copy / mesh_destroy) that gen-ctl-io does
# not emit. Treating it as a regular distributed source (not BUILT) keeps
# Guile-detected builds from regenerating and clobbering those hooks.
EXTRA_DIST = gen-ctl-io.in README geom.scm geom-ctl-io-defaults.c nlopt.c geom-ctl-io.c

libctlgeom_la_SOURCES = geom.c $(top_srcdir)/src/ctl-math.c $(top_srcdir)/src/integrator.c geom-ctl-io.c ctlgeom-types.h
libctlgeom_la_LDFLAGS = -version-info @SHARED_VERSION_INFO@
Expand All @@ -34,7 +39,7 @@ TESTS = test-prism test-mesh

dist_man_MANS = gen-ctl-io.1

BUILT_SOURCES = gen-ctl-io geom-ctl-io.c ctlgeom-types.h nlopt-constants.scm
BUILT_SOURCES = gen-ctl-io ctlgeom-types.h nlopt-constants.scm

nlopt-constants.scm:
echo "#include <nlopt.h>" > nlopt-constants.h
Expand All @@ -58,10 +63,7 @@ ctlgeom-types.h: ctl-io.h
echo '# define LIBCTL_BUGFIX_VERSION '$(LIBCTL_BUGFIX_VERSION) >> $@
echo '#endif' >> $@

geom-ctl-io.c: ctl-io.c
sed 's,ctl-io\.h,ctlgeom-types.h,;s,/.* Input variables .*/,@#include "geom-ctl-io-defaults.c"@#if 0@,;s,/.* Output variables .*/,#endif@,' ctl-io.c | tr '@' '\n' > $@

endif

clean-local:
rm -f ctl-io.[ch] nlopt-constants.scm ctlgeom-types.h geom-ctl-io.c
rm -f ctl-io.[ch] nlopt-constants.scm ctlgeom-types.h
Loading
Loading