Skip to content

Reject too-long HCA names#92

Open
fallintoplace wants to merge 1 commit into
NVIDIA:develfrom
fallintoplace:fix-hca-list-name-length
Open

Reject too-long HCA names#92
fallintoplace wants to merge 1 commit into
NVIDIA:develfrom
fallintoplace:fix-hca-list-name-length

Conversation

@fallintoplace

Copy link
Copy Markdown

Summary

  • Reject HCA list entries whose names would exceed the fixed nvshmemt_hca_info::name buffer.
  • Propagate parser failures through shared HCA filter setup and the IB transport init paths that consume it.

Root cause

nvshmemt_parse_hca_list() appended HCA name characters without checking the name[64] capacity. The unsafe append is present from the public import; later shared-IB refactoring preserved the behavior.

Testing

  • git diff --check
  • CMake configure attempted with tests enabled and unrelated build pieces disabled; blocked locally because CUDA toolkit / nvcc is not installed (Failed to find nvcc).

Signed-off-by: Minh Vu <vuhoangminh97@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant