Tolerate EEXIST in make_ancestors()#378
Open
rdjjke wants to merge 1 commit into
Open
Conversation
Signed-off-by: Mikhail Mokrushin <rodrijjke@nebius.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now, the
file_createfunction (used to create destination placeholders for bind-mounts) doesn't fail if any target file already exists, which can happen ifnvidia-container-cli configureruns concurrently for the same path. However, the creation of the parent directories is not equally race-tolerant.make_ancestorschecks whether each directory exists before callingmkdir. If another process creates the directory in the window between that check and themkdir, themkdirfails withEEXISTand aborts the wholenvidia-container-cli configure.This PR contains a small patch to tolerate
EEXISTinmake_ancestors, matching the idiom already used for the finalmkdir/symlinkinfile_create.