Skip to content

fix(cli): correct case sensitive identifiers#168

Merged
coryrylan merged 1 commit into
mainfrom
topic-cli-name-fix
Jun 30, 2026
Merged

fix(cli): correct case sensitive identifiers#168
coryrylan merged 1 commit into
mainfrom
topic-cli-name-fix

Conversation

@coryrylan

@coryrylan coryrylan commented Jun 30, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Bug Fixes
    • Updated the CLI/MCP server identifier to use the correct io.github.NVIDIA/elements casing.
    • Kept the server’s behavior unchanged while making its displayed name consistent across configuration and startup.

Signed-off-by: Cory Rylan <crylan@nvidia.com>
@coryrylan coryrylan self-assigned this Jun 30, 2026
@github-actions github-actions Bot added scope(cli) dependencies Pull requests that update a dependency file labels Jun 30, 2026
@coderabbitai

coderabbitai Bot commented Jun 30, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: 9475e837-66ad-4eea-92e8-2b5be644fc07

📥 Commits

Reviewing files that changed from the base of the PR and between 089acec and 3772d4d.

📒 Files selected for processing (3)
  • projects/cli/package.json
  • projects/cli/server.json
  • projects/cli/src/mcp/index.ts

📝 Walkthrough

Walkthrough

This change updates the MCP server identifier string from lowercase io.github.nvidia/elements to io.github.NVIDIA/elements in three locations: package.json's release configuration, server.json's name field, and the startMcpServer() function's server name literal in index.ts.

Changes

MCP Identifier Case Update

Layer / File(s) Summary
MCP identifier casing fix
projects/cli/package.json, projects/cli/server.json, projects/cli/src/mcp/index.ts
The MCP server identifier string is changed from io.github.nvidia/elements to io.github.NVIDIA/elements consistently in the release config, server manifest, and server initialization code.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • NVIDIA/elements#103: Originally introduced the mcpName field in package.json with the lowercase io.github.nvidia/elements value that this PR corrects.
  • NVIDIA/elements#118: Also modifies the MCP server name string in startMcpServer().

Suggested reviewers

  • johnyanarella
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the case-only identifier updates in the CLI release, server, and MCP name fields.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch topic-cli-name-fix

Comment @coderabbitai help to get the list of available commands.

@coryrylan coryrylan merged commit 6c8cd2b into main Jun 30, 2026
14 checks passed
@coryrylan coryrylan deleted the topic-cli-name-fix branch June 30, 2026 23:43
@coryrylan

Copy link
Copy Markdown
Collaborator Author

🎉 This issue has been resolved in version 2.1.3 🎉

Changelog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file released scope(cli)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant