Update cudnn-frontend to 1.23.0#3003
Conversation
Signed-off-by: ksivamani <ksivamani@nvidia.com>
Greptile SummaryThis PR bumps the
Confidence Score: 5/5Safe to merge — the submodule now points to the official v1.23.0 tagged commit and no TE source files were changed. The only change is the submodule pointer update to fb682ce7, confirmed to match the v1.23.0 release tag on NVIDIA/cudnn-frontend. The fixup commit resolved the earlier incorrect SHA. No consuming code in TransformerEngine was altered, and the pre-existing version guard remains satisfied. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A["PR #3003: Update cudnn-frontend to 1.23.0"] --> B["Commit 22b34608\nUpdate cudnn-FE to 1.23.0\n(initial, wrong SHA)"]
B --> C["Commit b5b0e4e1\nPoint to correct commit\n(fixup)"]
C --> D["3rdparty/cudnn-frontend\nSHA: fb682ce7"]
D --> E{"Matches v1.23.0 tag?"}
E -->|"Yes ✓"| F["Official NVIDIA/cudnn-frontend\nv1.23.0 release"]
F --> G["CUDNN_FRONTEND_VERSION >= 10601\nstatic_assert passes ✓"]
Reviews (2): Last reviewed commit: "Point to correct commit" | Re-trigger Greptile |
| @@ -1 +1 @@ | |||
| Subproject commit 97f6cb3b88cacff507cca1280db5650a457d92b3 | |||
| Subproject commit 60e572b7c8fe1976631af4141f307900ef17cad5 | |||
There was a problem hiding this comment.
Submodule commit doesn't match the tagged v1.23.0 release
The PR title says this updates to v1.23.0, but the pinned commit 60e572b7c8fe1976631af4141f307900ef17cad5 does not correspond to the official v1.23.0 tag on NVIDIA/cudnn-frontend, which points to commit fb682ce. The pinned commit is either a post-tag fix on the release branch or is from an entirely different branch. Could you confirm that 60e572b7 is intentionally chosen over the tagged release commit, and clarify which branch it lives on?
Signed-off-by: ksivamani <ksivamani@nvidia.com>
Description
Update
cudnn-frontendto 1.23.0Type of change
Changes
cudnn-frontendto 1.23.0Checklist: