Skip to content

Update cudnn-frontend to 1.23.0#3003

Open
ksivaman wants to merge 2 commits into
NVIDIA:mainfrom
ksivaman:cudnn_fe_1_23
Open

Update cudnn-frontend to 1.23.0#3003
ksivaman wants to merge 2 commits into
NVIDIA:mainfrom
ksivaman:cudnn_fe_1_23

Conversation

@ksivaman
Copy link
Copy Markdown
Member

Description

Update cudnn-frontend to 1.23.0

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refactoring

Changes

  • Update cudnn-frontend to 1.23.0

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Signed-off-by: ksivamani <ksivamani@nvidia.com>
@ksivaman ksivaman requested a review from cyanguwa May 17, 2026 01:25
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 17, 2026

Greptile Summary

This PR bumps the 3rdparty/cudnn-frontend git submodule to v1.23.0 (fb682ce7), which is the official tagged release on NVIDIA/cudnn-frontend. A second fixup commit ("Point to correct commit") corrected an initially wrong submodule SHA that was caught in a prior review round.

  • The pinned commit fb682ce7 matches the v1.23.0 release tag on GitHub, verified against the upstream release page.
  • No source files in the TransformerEngine codebase were modified; the existing minimum-version guard (CUDNN_FRONTEND_VERSION >= 10601) remains satisfied by 1.23.0.

Confidence Score: 5/5

Safe to merge — the submodule now points to the official v1.23.0 tagged commit and no TE source files were changed.

The only change is the submodule pointer update to fb682ce7, confirmed to match the v1.23.0 release tag on NVIDIA/cudnn-frontend. The fixup commit resolved the earlier incorrect SHA. No consuming code in TransformerEngine was altered, and the pre-existing version guard remains satisfied.

No files require special attention.

Important Files Changed

Filename Overview
3rdparty/cudnn-frontend Submodule pointer updated to fb682ce7, which is the official v1.23.0 tagged release commit on NVIDIA/cudnn-frontend; a prior fixup commit corrected an initially wrong pointer

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["PR #3003: Update cudnn-frontend to 1.23.0"] --> B["Commit 22b34608\nUpdate cudnn-FE to 1.23.0\n(initial, wrong SHA)"]
    B --> C["Commit b5b0e4e1\nPoint to correct commit\n(fixup)"]
    C --> D["3rdparty/cudnn-frontend\nSHA: fb682ce7"]
    D --> E{"Matches v1.23.0 tag?"}
    E -->|"Yes ✓"| F["Official NVIDIA/cudnn-frontend\nv1.23.0 release"]
    F --> G["CUDNN_FRONTEND_VERSION >= 10601\nstatic_assert passes ✓"]
Loading

Reviews (2): Last reviewed commit: "Point to correct commit" | Re-trigger Greptile

Comment thread 3rdparty/cudnn-frontend Outdated
@@ -1 +1 @@
Subproject commit 97f6cb3b88cacff507cca1280db5650a457d92b3
Subproject commit 60e572b7c8fe1976631af4141f307900ef17cad5
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Submodule commit doesn't match the tagged v1.23.0 release

The PR title says this updates to v1.23.0, but the pinned commit 60e572b7c8fe1976631af4141f307900ef17cad5 does not correspond to the official v1.23.0 tag on NVIDIA/cudnn-frontend, which points to commit fb682ce. The pinned commit is either a post-tag fix on the release branch or is from an entirely different branch. Could you confirm that 60e572b7 is intentionally chosen over the tagged release commit, and clarify which branch it lives on?

Signed-off-by: ksivamani <ksivamani@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant