fix(vm): use bash 3.2-safe empty array expansion in supervisor build#1311
Merged
Conversation
…script
macOS ships bash 3.2, which treats empty array expansion ("${arr[@]}")
as an unbound variable error under set -u. Unlike set -e, this error
is not caught by if-constructs — it kills the shell immediately with
no output, causing mise run vm:supervisor to fail silently.
Use the ${arr[@]+"${arr[@]}"} idiom so the script works on both
bash 3.2 (macOS default) and bash 4+.
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
benoitf
requested review from
a team,
derekwaynecarr,
maxamillion and
mrunalp
as code owners
benoitf
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
mise run vm:supervisorsilently failing on macOS. Bash 3.2 (the macOS default) treats empty array expansion ("${arr[@]}") as an unbound variable error underset -u. Unlikeset -e, this error bypassesif-constructs and kills the shell immediately with no output. The fix uses the${arr[@]+"${arr[@]}"}idiom, which is safe on both bash 3.2 and 4+.Related Issue
#635
Changes
"${cargo_prefix[@]}"with${cargo_prefix[@]+"${cargo_prefix[@]}"}on bothcargo zigbuildandcargo buildinvocation lines intasks/scripts/vm/build-supervisor-bundle.shTesting
mise run pre-commitpassesChecklist