chore(skills): add dynamic plugin maintainer guidance#312
Draft
willkill07 wants to merge 1 commit into
Draft
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
github-actions
Bot
added
size:XXL
willkill07
force-pushed
the
wkk_dynamic-plugin-8-skills
branch
from
1cdbe93 to
73b08c3
Compare
willkill07
force-pushed
the
wkk_dynamic-plugin-8-skills
branch
from
73b08c3 to
51efbf2
Compare
willkill07
force-pushed
the
wkk_dynamic-plugin-8-skills
branch
from
51efbf2 to
744b9f9
Compare
willkill07
force-pushed
the
wkk_dynamic-plugin-8-skills
branch
from
744b9f9 to
9989937
Compare
willkill07
force-pushed
the
wkk_dynamic-plugin-8-skills
branch
from
9989937 to
30b4f4f
Compare
willkill07
force-pushed
the
wkk_dynamic-plugin-8-skills
branch
from
30b4f4f to
0f7e347
Compare
willkill07
force-pushed
the
wkk_dynamic-plugin-8-skills
branch
from
0f7e347 to
baff0be
Compare
willkill07
force-pushed
the
wkk_dynamic-plugin-8-skills
branch
from
baff0be to
2281fc5
Compare
willkill07
force-pushed
the
wkk_dynamic-plugin-8-skills
branch
from
c73506d to
0541a88
Compare
willkill07
force-pushed
the
wkk_dynamic-plugin-8-skills
branch
from
0541a88 to
ae98192
Compare
willkill07
force-pushed
the
wkk_dynamic-plugin-8-skills
branch
from
ae98192 to
29155fe
Compare
willkill07
force-pushed
the
wkk_dynamic-plugin-8-skills
branch
from
29155fe to
bb216ed
Compare
willkill07
force-pushed
the
wkk_dynamic-plugin-8-skills
branch
from
bb216ed to
2032bc5
Compare
willkill07
force-pushed
the
wkk_dynamic-plugin-8-skills
branch
from
2032bc5 to
848538c
Compare
willkill07
force-pushed
the
wkk_dynamic-plugin-8-skills
branch
from
848538c to
684dd54
Compare
willkill07
force-pushed
the
wkk_dynamic-plugin-8-skills
branch
from
684dd54 to
da53150
Compare
willkill07
force-pushed
the
wkk_dynamic-plugin-8-skills
branch
from
da53150 to
12e56bc
Compare
willkill07
force-pushed
the
wkk_dynamic-plugin-8-skills
branch
from
12e56bc to
b9ee757
Compare
willkill07
force-pushed
the
wkk_dynamic-plugin-8-skills
branch
from
b9ee757 to
8a3371f
Compare
1 similar comment
Signed-off-by: Will Killian <wkillian@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Add focused maintainer Skills guidance for dynamic plugin development and route related validation, packaging, CI, Python, Rust, and documentation work to the right repository workflows.
Dependency: PR #310 should merge first because several Skills updates describe its Python worker SDK paths and commands: #310
Details
.agents/skills/maintain-dynamic-plugins/SKILL.md.just test-python-pluginrecipe.doctorfrompluginssubcommands, keep unmerged detailed-doc guidance conditional, and correct stale docs/workflow references..agents/skills/; it contains no runtime, SDK, workflow, packaging configuration, or docs-site content changes.Validation:
cargo test -p nemo-relay --features worker-grpc --test native_plugin_integration --test worker_plugin_integration --no-runuv run pre-commit run --files <seven changed SKILL.md files>uv run pre-commit run --all-filesWhere should the reviewer start?
Start with
.agents/skills/maintain-dynamic-plugins/SKILL.md, then review the routing additions in.agents/skills/validate-change/SKILL.md.Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)