ci: run path-gated unit test lanes on push events#1893
Conversation
For push events, neither branch of check-file-changes ran (one step covers schedule/workflow_dispatch, the other pull_request), so any_changed stayed empty and the windows, multi-version, partial-install, launcher, mcp, and skills lanes were all skipped on every push to main/release/feature branches despite the workflow-level paths filter listing their directories. Treating push like the other non-PR triggers is safe because that paths filter already guarantees a relevant file changed before the workflow starts. Signed-off-by: arham766 <arhamislam766@yahoo.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe workflow condition that triggers the "non-pr" change-detection step in unit_tests.yml is expanded to also run on push events, alongside schedule and workflow_dispatch, preventing gated test lanes from being silently skipped on push. ChangesCI Workflow Trigger Fix
Estimated code review effort: 1 (Trivial) | ~3 minutes Related PRs: None specified. Suggested labels: ci, github-actions Suggested reviewers: None specified. 🐰 A hop, a fix, a workflow's cheer, 🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
What does this PR do?
Type of change: Bug fix
In
check-file-changes, thenon-prstep ran only forschedule/workflow_dispatchand thechangedstep only forpull_request, so forpusheventsany_changedstayed empty and the windows, multi-version, partial-install, launcher, mcp, and skills lanes were all silently skipped — despite the workflow-level pushpaths:filter listing their directories. Treating push like the other non-PR triggers is safe because that paths filter already guarantees a relevant file changed before the workflow starts.Usage
N/A — CI workflow configuration change.
Testing
Evidence from run history: the latest push-event run on main shows check-file-changes success and every gated lane skipped (details in #1890). YAML validated.
Before your PR is "Ready for review"
CONTRIBUTING.md: N/A/claude review)Additional Information
Part of #1890 (item 3).
Summary by CodeRabbit