Skip to content

ci: run path-gated unit test lanes on push events#1893

Open
arham766 wants to merge 1 commit into
NVIDIA:mainfrom
arham766:ci-unit-tests-push-gate
Open

ci: run path-gated unit test lanes on push events#1893
arham766 wants to merge 1 commit into
NVIDIA:mainfrom
arham766:ci-unit-tests-push-gate

Conversation

@arham766

@arham766 arham766 commented Jul 2, 2026

Copy link
Copy Markdown

What does this PR do?

Type of change: Bug fix

In check-file-changes, the non-pr step ran only for schedule/workflow_dispatch and the changed step only for pull_request, so for push events any_changed stayed empty and the windows, multi-version, partial-install, launcher, mcp, and skills lanes were all silently skipped — despite the workflow-level push paths: filter listing their directories. Treating push like the other non-PR triggers is safe because that paths filter already guarantees a relevant file changed before the workflow starts.

Usage

N/A — CI workflow configuration change.

Testing

Evidence from run history: the latest push-event run on main shows check-file-changes success and every gated lane skipped (details in #1890). YAML validated.

Before your PR is "Ready for review"

  • Is this change backward compatible?: ✅
  • If you copied code from any other sources or added a new PIP dependency, did you follow guidance in CONTRIBUTING.md: N/A
  • Did you write any new necessary tests?: N/A (workflow config; validated as described above)
  • Did you update Changelog?: N/A (CI-only change)
  • Did you get Claude approval on this PR?: N/A (external contributor; cannot trigger /claude review)

Additional Information

Part of #1890 (item 3).

Summary by CodeRabbit

  • Bug Fixes
    • Fixed an issue where test-related jobs could be skipped on push events.
    • Improved workflow behavior so change detection now runs consistently for push, scheduled, and manually triggered runs.

For push events, neither branch of check-file-changes ran (one step
covers schedule/workflow_dispatch, the other pull_request), so
any_changed stayed empty and the windows, multi-version,
partial-install, launcher, mcp, and skills lanes were all skipped on
every push to main/release/feature branches despite the workflow-level
paths filter listing their directories. Treating push like the other
non-PR triggers is safe because that paths filter already guarantees a
relevant file changed before the workflow starts.

Signed-off-by: arham766 <arhamislam766@yahoo.com>
@arham766 arham766 requested a review from a team as a code owner July 2, 2026 21:27
@arham766 arham766 requested a review from kevalmorabia97 July 2, 2026 21:27
@copy-pr-bot

copy-pr-bot Bot commented Jul 2, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@coderabbitai

coderabbitai Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: ca6ed880-4d4b-4b4c-be5c-d939cff51893

📥 Commits

Reviewing files that changed from the base of the PR and between 4b9225b and bae5a45.

📒 Files selected for processing (1)
  • .github/workflows/unit_tests.yml

📝 Walkthrough

Walkthrough

The workflow condition that triggers the "non-pr" change-detection step in unit_tests.yml is expanded to also run on push events, alongside schedule and workflow_dispatch, preventing gated test lanes from being silently skipped on push.

Changes

CI Workflow Trigger Fix

Layer / File(s) Summary
Include push in change-detection condition
.github/workflows/unit_tests.yml
The conditional gating the step that sets any_changed now also triggers on push events, with added comments explaining the prior gap.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Related PRs: None specified.

Suggested labels: ci, github-actions

Suggested reviewers: None specified.

🐰 A hop, a fix, a workflow's cheer,
Push events now bring test lanes near,
No more silence when code takes flight,
The change-detection burns ever bright.

🚥 Pre-merge checks | ✅ 6
✅ Passed checks (6 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main CI fix: enabling path-gated unit test lanes on push events.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Security Anti-Patterns ✅ Passed No forbidden anti-patterns appear in modelopt/examples source diffs; security flags stay configurable, and no new unsafe loads/nosec/eval/exec were added.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant