ci: gate example and GPU tests on changes to their own runner and cache action#1891
Open
arham766 wants to merge 1 commit into
Open
ci: gate example and GPU tests on changes to their own runner and cache action#1891arham766 wants to merge 1 commit into
arham766 wants to merge 1 commit into
Conversation
…he action The example_tests pr-gate does not list _example_tests_runner.yml (the reusable workflow that runs every example-test job) or the cache-extensions composite action it uses, so a PR changing only those files skips the very jobs it rewires and merges green (e.g. PR NVIDIA#1651: pr-gate passed, torch/trtllm-pr/megatron/onnx all skipped). Same for cache-extensions in gpu_tests.yml, which uses the action in its runner step. Reusable workflows run from the PR ref, so gating on them is the intended self-testing behavior already applied to example_tests.yml itself. Signed-off-by: arham766 <arhamislam766@yahoo.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis PR extends the Changespr-gate File Path Updates
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Type of change: Bug fix
Adds
.github/workflows/_example_tests_runner.ymland.github/actions/cache-extensions/**to the example_tests pr-gatefiles:list, andcache-extensions/**to the gpu_tests gate. Every example-test job executes through the reusable runner (which is taken from the PR's ref), so a PR changing only the runner previously merged with all example-test jobs skipped — observed on PR #1651, whose example-tests run shows pr-gate success with torch/trtllm-pr/megatron/onnx all skipped. Gating on the workflow's own machinery matches the existing intent (the gate already listsexample_tests.ymlitself).Usage
N/A — CI workflow configuration change.
Testing
YAML validated; the change is additive to the gate lists only. The observed-failure evidence is PR #1651's run history (linked in #1890).
Before your PR is "Ready for review"
CONTRIBUTING.md: N/A/claude review)Additional Information
Part of #1890 (item 1).
Summary by CodeRabbit