Skip to content

Fix compiled external source tests on Python 3.10#6424

Open
rostan-t wants to merge 1 commit into
NVIDIA:mainfrom
rostan-t:ndd-fix-compile-test-3.10
Open

Fix compiled external source tests on Python 3.10#6424
rostan-t wants to merge 1 commit into
NVIDIA:mainfrom
rostan-t:ndd-fix-compile-test-3.10

Conversation

@rostan-t

Copy link
Copy Markdown
Collaborator

Category:

Other (e.g. Documentation, Tests, Configuration)

Description:

On Python 3.10, call site detection doesn't work if multiple calls are on the same line. This is currently the case for two tests in test_compile.py. This PR fixes this.

Additional information:

Affected modules and functionalities:

Key points relevant for the review:

Tests:

  • Existing tests apply
    • test_compile.py: test_compile_es_cycle_raise
    • test_compile.py: test_compile_es_feeder
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Checklist

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

Signed-off-by: Rostan Tabet <rtabet@nvidia.com>
@greptile-apps

greptile-apps Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR updates two compiled external source tests for Python 3.10 call-site handling. The main changes are:

  • Splits a nested ndd.as_tensor(ndd.cast(...)) expression across multiple lines.
  • Moves other_comp() into its own statement before passing the result to ndd.cast.
  • Keeps the existing compiled-result and parity checks unchanged.

Confidence Score: 5/5

This looks safe to merge.

  • No blocking issues found in the changed code.

Important Files Changed

Filename Overview
dali/test/python/experimental_mode/test_compile.py Adjusts two test expressions so relevant calls are no longer packed onto the same source line.

Reviews (1): Last reviewed commit: "Fix compiled external source tests on Py..." | Re-trigger Greptile

Comment thread dali/test/python/experimental_mode/test_compile.py Dismissed
@rostan-t

Copy link
Copy Markdown
Collaborator Author

!build

@dali-automaton

Copy link
Copy Markdown
Collaborator

CI MESSAGE: [57815491]: BUILD STARTED

@dali-automaton

Copy link
Copy Markdown
Collaborator

CI MESSAGE: [57815491]: BUILD PASSED

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants