Fix compiled external source tests on Python 3.10#6424
Open
rostan-t wants to merge 1 commit into
Open
Conversation
Signed-off-by: Rostan Tabet <rtabet@nvidia.com>
Contributor
|
| Filename | Overview |
|---|---|
| dali/test/python/experimental_mode/test_compile.py | Adjusts two test expressions so relevant calls are no longer packed onto the same source line. |
Reviews (1): Last reviewed commit: "Fix compiled external source tests on Py..." | Re-trigger Greptile
Collaborator
Author
|
!build |
Collaborator
|
CI MESSAGE: [57815491]: BUILD STARTED |
mzient
approved these changes
Jul 13, 2026
Collaborator
|
CI MESSAGE: [57815491]: BUILD PASSED |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Category:
Other (e.g. Documentation, Tests, Configuration)
Description:
On Python 3.10, call site detection doesn't work if multiple calls are on the same line. This is currently the case for two tests in
test_compile.py. This PR fixes this.Additional information:
Affected modules and functionalities:
Key points relevant for the review:
Tests:
test_compile.py:test_compile_es_cycle_raisetest_compile.py:test_compile_es_feederChecklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A