Support random ops in transparent pipelining#6423
Open
rostan-t wants to merge 3 commits into
Open
Conversation
Signed-off-by: Rostan Tabet <rtabet@nvidia.com>
Signed-off-by: Rostan Tabet <rtabet@nvidia.com>
Contributor
|
| Filename | Overview |
|---|---|
| dali/python/nvidia/dali/experimental/dynamic/_compile.py | Adds compiled RNG ownership, pruning, call-order checks, state syncing, and graph wiring for random operators. |
| dali/python/nvidia/dali/experimental/dynamic/_ops.py | Routes random-state argument creation through shared RNG helper functions. |
| dali/python/nvidia/dali/experimental/dynamic/random.py | Refactors RNG state handling and adds helpers for drawn random-state tensors. |
| dali/test/python/experimental_mode/test_compile.py | Adds compiled random parity tests for multiple RNGs, fallback, reuse, epochs, and GPU execution. |
| dali/test/python/experimental_mode/test_random.py | Updates RNG tests for the helper-based state path and adds coverage for advance. |
Reviews (3): Last reviewed commit: "Add compiled rng tests" | Re-trigger Greptile
2e6b57e to
1025ecf
Compare
Signed-off-by: Rostan Tabet <rtabet@nvidia.com>
1025ecf to
ff79570
Compare
Collaborator
Author
|
!build |
Collaborator
|
CI MESSAGE: [57815527]: BUILD STARTED |
Collaborator
|
CI MESSAGE: [57815527]: BUILD PASSED |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Category:
New feature (non-breaking change which adds functionality)
Description:
This PR add support for random operators in transparent pipelining, ensuring parity between eager and compiled modes. When parity is not possible, operators fall back to eager mode when detected during tracing, or error out if a discrepancy happens after tracing.
Additional information:
Affected modules and functionalities:
Dynamic mode, transparent pipelining
Key points relevant for the review:
Tests:
test_compile.pyChecklist
Documentation
Transparent pipelining doesn't have documentation yet.
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: DALI-4670