Skip to content

Feat: Harden governance approval workflow#28

Merged
rian-be merged 2 commits into
mainfrom
develop
Jun 24, 2026
Merged

Feat: Harden governance approval workflow#28
rian-be merged 2 commits into
mainfrom
develop

Conversation

@rian-be

@rian-be rian-be commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Summary

This PR hardens the governance approval workflow so it supports richer operational approval behavior instead of only the initial linear slice.

Added

  • role and group targeted approval requirements
  • quorum support for grouped approvals
  • approval specific expiration handling
  • structured approval rejection reasons
  • domain specific approval exceptions
  • approval workflow example coverage for multi actor and quorum scenarios

Changed

  • approval workflow runtime split into validator, decision executor, expiration executor, and guarded persistence
  • approval requirements can now carry role, group, quorum, and expiration metadata
  • request approval decisions now record quorum satisfaction and expiration explicitly
  • approval docs and ADRs updated to reflect the hardened semantics

Result

Approval workflow is now expressive enough for multi actor governance flows while staying request centric and auditable.

Testing

  • dotnet build src/ModularityKit.Mutator.Governance.csproj -c Release
  • dotnet build Examples/Governance/ApprovalWorkflow/ApprovalWorkflow.csproj -c Release
  • dotnet test Tests/ModularityKit.Mutator.Governance.Tests/ModularityKit.Mutator.Governance.Tests.csproj -c Release

Linked Issues

Checklist

  • Approval workflow supports grouped and quorum based approvals
  • Approval failures use domain specific exceptions and structured rejection reasons
  • Approval expiration is explicit and auditable
  • Tests cover multi actor approval behavior
  • Example coverage demonstrates non trivial approval scenarios

@github-actions github-actions Bot added documentation Documentation updates and additions architecture Design, structure, and API-shape changes examples Runnable examples and sample apps tests Test coverage and test changes labels Jun 24, 2026
@rian-be rian-be merged commit b95bc0f into main Jun 24, 2026
12 checks passed
@rian-be rian-be deleted the develop branch June 24, 2026 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

architecture Design, structure, and API-shape changes documentation Documentation updates and additions examples Runnable examples and sample apps tests Test coverage and test changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Task]: Harden governance approval workflow semantics

1 participant