Skip to content

Reorder fonts to match API order #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MitchellAW merged 2 commits into from
Jun 17, 2026
Merged

Reorder fonts to match API order #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8723c97
Reorder universal & allowed fonts to match API
MitchellAW Jun 17, 2026
01cb54a
Document upcoming font reorder change
MitchellAW Jun 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion compuglobal/aio.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ def __init__(self, session: aiohttp.ClientSession, default_format: OverlayFormat
chosen_font = extra_fonts[0] if len(extra_fonts) > 0 else FontFamily.IMPACT
default_format = OverlayFormat(font_family=chosen_font)

allowed_fonts = FontFamily.universal_fonts() + extra_fonts
allowed_fonts = extra_fonts + FontFamily.universal_fonts()

self.config = CompuGlobalAPIConfig(
title=self.TITLE,
Expand Down
2 changes: 1 addition & 1 deletion compuglobal/models/font.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,8 @@ def universal_fonts() -> list["FontFamily"]:
return [
FontFamily.IMPACT,
FontFamily.COMIC_NEUE,
FontFamily.JOST,
FontFamily.PACIFICO,
FontFamily.JOST,
]


Expand Down
8 changes: 8 additions & 0 deletions docs/changelog.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,14 @@

Changelog
=========

Upcoming Changes
----------------

Miscellaneous
~~~~~~~~~~~~~
- Reorder fonts in :meth:`FontFamily.universal_fonts` and :attr:`CompuGlobalAPIConfig.allowed_fonts` to match the order used by the API.

0.4.2
-----

Expand Down