Add support for aifs-single-1.1#190
Conversation
There was a problem hiding this comment.
I am not sure we need to even define GRIB templates. Have you tried without?
There was a problem hiding this comment.
I was also confused, but it was failing without...
| # - init_hour | ||
| - season | ||
| stratification: | ||
| regions: [] |
There was a problem hiding this comment.
What is the current behavior w.r.t. regions stratification? For instance here we pass an empty list - it means we compute the verification globally or only over the Alpine domain?
There was a problem hiding this comment.
the "all" region is currently hardcoded, see
evalml/src/verification/__init__.py
Line 49 in cc58366
| templates: | ||
| samples: resources/templates_index_global-ea.yaml | ||
|
|
||
| write_initial_state: false |
There was a problem hiding this comment.
Why is that? Could still be nice to see especially when comparing against observations.
There was a problem hiding this comment.
mmmh it might be a leftover from when I was debugging the grib template issue, I'll try to remove it!
MicheleCattaneo
left a comment
MicheleCattaneo
left a comment
There was a problem hiding this comment.
It seem to be looking good. I could only spot one thing so far, made a minor comment
Co-authored-by: Michele Cattaneo <44707621+MicheleCattaneo@users.noreply.github.com>
3 participants
No description provided.