CI: build Python bindings with Clang 21 on Ubuntu (was Clang 18)#6299
Open
Fedr wants to merge 1 commit into
Open
CI: build Python bindings with Clang 21 on Ubuntu (was Clang 18)#6299Fedr wants to merge 1 commit into
Fedr wants to merge 1 commit into
Conversation
Bump the Linux MRBind Clang version in `clang_version.txt` from 18 to 21, so ubuntu22 and ubuntu24 generate and build the Python bindings with Clang 21. This is the single source of truth read by the Ubuntu Docker images (`install_deps_ubuntu.sh`), the MRBind build, and `generate.mk`. Also add `scripts/mrbind/clang_version.txt` to the `linux-changes` path filter in config.yml. The Ubuntu images bake in the bindings Clang at image-build time, so without this the prebuilt image would stay on Clang 18 and `install_mrbind_ubuntu.sh` would fail to find clang-21. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Fedr
added
disable-build-windows
disable-build-macos
disable-build-emscripten
disable-build-linux-vcpkg
full-ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bump the Linux MRBind Clang version from 18 to 21 so the Ubuntu images (
ubuntu22,ubuntu24) generate and build the Python bindings with Clang 21.Changes
scripts/mrbind/clang_version.txt:18→21. This file is the single source of truth for the Linux bindings Clang — it's read by the Ubuntu Docker images (install_deps_ubuntu.shinstallsclang-$VERvia apt.llvm.org), the MRBind build (install_mrbind_ubuntu.sh), and bindings generation (generate.mk)..github/workflows/config.yml: addscripts/mrbind/clang_version.txtto thelinux-changespath filter. The bindings Clang is baked into the Ubuntu images at image-build time, so without this the prebuilt image would stay on Clang 18 andinstall_mrbind_ubuntu.shwould fail to findclang-21. Adding it forces an image rebuild whenever the version changes.Scope / affected platforms
clang_version.txtis the Linux bindings Clang shared by theubuntu22/ubuntu24images (x64 + arm64) and theemscripten-c-bindingsimage used bygenerate-c-bindings, so the C bindings move to Clang 21 too (consistent — there is only one Linux bindings Clang version).Unaffected, so disabled on this PR:
clang_version.txt).clang_version_macos.txt(already 22).clang/clang++(Clang 21) from its rockylinux image; cache key is the Dockerfile, notclang_version.txt.emscriptenimage, which does not readclang_version.txt. The C-bindings path (emscripten-c-bindingsimage +generate-c-bindings) always runs regardless of this label, so the Clang 21 C-bindings generation is still exercised.Clang 21 is already used elsewhere in CI (the rockylinux vcpkg images), confirming the toolchain is available.