Refactor compose file flag into shared OptionGroup for up, down, and build.#98
Merged
Conversation
Copilot
AI
changed the title
Move compose file option into shared OptionGroup
Refactor compose file flag into shared OptionGroup for May 30, 2026
up and down
Copilot created this pull request from a session on behalf of
Mcrich23
May 30, 2026 17:55
View session
Mcrich23
requested changes
May 30, 2026
| @testable import ContainerComposeCore | ||
|
|
||
| @Suite("Compose command parsing") | ||
| struct ComposeCommandParsingTests { |
Owner
There was a problem hiding this comment.
These tests are kinda useless. However, check if calling "-f", "up" on the main entry point command is valid.
| } | ||
| print( | ||
| "Info: Service '\(serviceName)' is configured to connect to networks: \(serviceNetworks.joined(separator: ", ")) ascertained from networks attribute in \(composeFilename)." | ||
| "Info: Service '\(serviceName)' is configured to connect to networks: \(serviceNetworks.joined(separator: ", ")) ascertained from networks attribute in \(composePath)." |
Owner
There was a problem hiding this comment.
Double check the change on this variable name
Owner
|
This looks decent @copilot. Please look at the comments I left. |
Copilot stopped work on behalf of
Mcrich23 due to an error
May 30, 2026 18:04
Copilot stopped work on behalf of
Mcrich23 due to an error
May 30, 2026 18:05
Copilot stopped work on behalf of
Mcrich23 due to an error
May 30, 2026 18:06
up and downup, down, and build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The compose file flag handling was duplicated across the two compose commands that accept
-f/--file. This change centralizes that option in a shared argument group and wires both commands to consume it consistently.Shared CLI option model
ComposeFileOptionsas a reusableParsableArgumentstype for-f/--file.Command integration
ComposeUpto use@OptionGroup var composeFileOptions.ComposeDownto use@OptionGroup var composeFileOptions.Parsing coverage
ComposeUpandComposeDownboth accept-f my-compose.yamlthrough the shared group.