refactor: use ES module imports in browser core#4158
Open
KristjanESPERANTO wants to merge 3 commits into
Open
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Private helpers clashing with public MM methods get an underscore prefix. globalThis.MM stays as a fallback for third-party modules.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With these changes a few browser-side core files now use native ES modules.
Loader,MMSocket,ModuleandMMcan be imported directly instead of being read offwindow.main.jsandloader.jsare no longer wrapped in IIFEs - they're just normal modules now.Module,MMandMMSocketare still exposed as globals, so third-party modules that use the old API keep working.The changes are mostly structural, behavior should stay the same. A few internal helpers in
main.jsgot an underscore prefix because their names clashed with publicMMmethods.Why
The old setup relied a lot on script order: a file could use
LoaderorMMSocketonly because another script happened to put it onwindowfirst. Imports make that explicit.The bigger goal is to move away from the legacy script-loading patterns - making it easier to understand and easier to test - in other words: easier to maintain.
More of the core could be "cleaned up" the same way, but that would blow up this PR.
For reviewing, I recommend to hide the whitespace changes.