fix systeminformation thread not ending#4155
Draft
khassel wants to merge 1 commit into
Draft
Conversation
KristjanESPERANTO
approved these changes
May 17, 2026
Collaborator
KristjanESPERANTO
left a comment
KristjanESPERANTO
left a comment
There was a problem hiding this comment.
Nice solution 👍 Why is this still a draft?
Collaborator
Author
|
it still does not work ... |
Collaborator
|
If you need help with further investigation: How are you reproducing the issue? I'm having trouble seeing it on my end - Worker threads die with the parent process, so no orphans under pm2. |
Collaborator
Author
|
as always within a container. This PR solves the problem where threads are not ending but systeminfo is not displayed ... will try again later or tomorrow. Which setup did you test with pm2 (with this PR or without or both)? |
Collaborator
|
Both, but now I see the issue with the missing output when the config has an error, but no approach to solve it. |
Collaborator
Author
|
I have now an ugly approach to solve it ... |
…without hanging shell
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was introduced when running systeminformation in an own thread.
If the main thread ends before (e.g. when config has errors) the systeminformation thread never ends.
As this can have side effects under pm2 or docker (because the app never exits) this PR restores the old behavior.