Feature: Add auto accept party request from friends and guild members

[eduardosmaniotto]

MU Helper: new flags, party auto-accept, combat update

New MU Helper flags — UseSelfDefense, AutoAcceptFriend, AutoAcceptGuild, FallbackBasicAttack added to the 257-byte client blob deserialization, IMuHelperSettings interface, and model class.

Party auto-accept — PartyRequestHandler.TryAutoAcceptPartyRequestAsync automatically accepts party requests when the receiver has AutoAcceptFriend (checked via IFriendServer.IsFriendAsync) or AutoAcceptGuild (same guild ID) enabled.

CombatHandler — removed buff-based early return. FallbackBasicAttack flag controls whether basic attack is performed when no skill is configured.

Friend server — added IsFriendAsync to IFriendServer (in-memory + Dapr). DeleteFriendAsync now cleans up both directions (subscribers + persistence).

Immediate effect — MU Helper config saves (0xAE packet) re-deserialize player.MuHelperSettings so flag changes apply without relog.

Tests — 6 party auto-accept tests, CombatHandlerTests updated.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces significant improvements to the MU Helper system, primarily focusing on automated party management and combat flexibility. By adding new configuration flags, players can now opt-in to automatically accept party requests from friends and guild members. Additionally, the combat logic has been refined to provide better control over attack behavior, and the friend server infrastructure has been updated to support more robust friendship checks and cleanup.

Highlights

• MU Helper Enhancements: Added new configuration flags (UseSelfDefense, AutoAcceptFriend, AutoAcceptGuild, FallbackBasicAttack) to the MU Helper settings, enabling more granular control over automated gameplay behavior.
• Party Auto-Accept System: Implemented a new PartyRequestHandler that automatically accepts party requests from friends or guild members if the corresponding MU Helper flags are enabled.
• Combat Logic Update: Refactored CombatHandler to remove buff-based early returns and introduced the FallbackBasicAttack flag to allow basic attacks when primary skills are unavailable.
• Friend Server Improvements: Extended IFriendServer with an IsFriendAsync method and improved DeleteFriendAsync to ensure consistent cleanup of friendship records in both directions.

New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request implements auto-accepting party requests from friends and guild members based on MU Helper settings, introducing the PartyRequestHandler and adding the IsFriendAsync method to the friend server. It also updates the offline combat handler to support basic attack fallback and bow/crossbow range detection, alongside serializing the new configuration flags. A correctness bug was identified in PartyRequestHandler.TryAutoAcceptPartyRequestAsync where a failed party join clears the request state but returns false, leading to a broken manual request dialog fallback; it is recommended to return true once the auto-accept criteria are matched to prevent this fallback.

[sven-n]

Nice features, I like them! Is the client getting updated as well?

[eduardosmaniotto]

The flags already exist on the client but are currently not being used.