Skip to content

fix(web): remove redundant truthiness check (CodeQL js/trivial-conditional) #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Musiker15 merged 1 commit into from
Jun 20, 2026
Merged

fix(web): remove redundant truthiness check (CodeQL js/trivial-conditional) #56

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion apps/web/src/app/api/forms/[slug]/submit/route.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,8 @@ function buildPreview(spec: FormSpec, data: Record<string, unknown>): string[] {
if (value === undefined || value === null || value === "") return "—";
if (typeof value === "boolean") return value ? "Yes" : "No";
if (Array.isArray(value)) return value.map((v) => labelFor(field, String(v))).join(", ");
if (typeof value === "object" && value && "name" in value) {
// null/undefined already returned above, so a plain object check suffices.
if (typeof value === "object" && "name" in value) {
return String((value as { name: unknown }).name);
}
if (field.options) return labelFor(field, String(value));
Expand Down