Feature/regex match speedup#1456
Open
yjwu890355 wants to merge 1 commit into
Open
Conversation
Compile the diagnostic output regex pattern once and reuse it across all stream name checks instead of calling regcomp() for every comparison. This avoids repeated regex compilation overhead in regex_matching.c, which could account for more than 30% of execution time. Timer information shows 10x speedup in 'diagnostic_fields' on CWA Fujitsu FX1000 machine Credit: Yu-Tze Hong <aspen.hong@gmail.com>
Contributor
|
@yjwu890355 Thank you for identifying this opportunity to speed up regular expression matching. Under the assumption that most calls to the Would you be willing to consider the code changes in commit ae7a389 instead? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Speed up regex matching in diagnostic output
Compile the diagnostic output regex pattern once and reuse it across all stream
name checks instead of calling regcomp() for every comparison. This avoids
repeated regex compilation overhead in regex_matching.c, which could account for
more than 30% of execution time.
Timer information shows 10x speedup in 'diagnostic_fields' on CWA Fujitsu FX1000 machine
Credit: Yu-Tze Hong aspen.hong@gmail.com