Skip to content

fix(web-ui): don't open ui automatically on app start#5329

Open
s-h-a-d-o-w wants to merge 1 commit into
LizardByte:masterfrom
s-h-a-d-o-w:fix/dont-auto-open-ui
Open

fix(web-ui): don't open ui automatically on app start#5329
s-h-a-d-o-w wants to merge 1 commit into
LizardByte:masterfrom
s-h-a-d-o-w:fix/dont-auto-open-ui

Conversation

@s-h-a-d-o-w

@s-h-a-d-o-w s-h-a-d-o-w commented Jun 24, 2026 •
edited by ReenigneArcher
Loading

Copy link
Copy Markdown

Description

This seems like a UX anti-pattern for an app that's running in the background, with only occasional config to be done. And @ReenigneArcher recently argued that a PR would be welcome.

Issues Fixed or Closed

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@sonarqubecloud

sonarqubecloud Bot commented Jun 24, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

ReenigneArcher
ReenigneArcher requested changes Jun 24, 2026
View reviewed changes
Comment thread packaging/linux/flatpak/scripts/sunshine.sh
Comment on lines 2 to 10

PORT=47990

if ! curl -k https://localhost:$PORT > /dev/null 2>&1; then
(sleep 3 && xdg-open https://localhost:$PORT) &
exec sunshine "$@"
else
echo "Sunshine is already running, opening the web interface..."
xdg-open https://localhost:$PORT
fi

@ReenigneArcher ReenigneArcher Jun 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

#!/bin/sh
exec sunshine "$@"

I think the script can be simplified to just this one command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ReenigneArcher ReenigneArcher ReenigneArcher requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@s-h-a-d-o-w @ReenigneArcher