Skip to content

perf: constant-time match lookups in standings model #7650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Rathoz wants to merge 1 commit into
base: standings-tests-ai
Choose a base branch
from
+3 −5
Open

perf: constant-time match lookups in standings model #7650

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions lua/wikis/commons/Standings.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,9 +175,10 @@ function Standings.fetchMatches(standings)
return MatchGroupUtil.splitMatchId(matchid)
end))

local wantedMatchIds = Table.map(matchids, function(_, matchid) return matchid, true end)
local allMatchesFromBrackets = Array.flatMap(bracketIds, MatchGroupUtil.fetchMatches)
return Array.filter(allMatchesFromBrackets, function(match)
return Table.includes(matchids, match.matchId)
return wantedMatchIds[match.matchId]
end)
end

Expand All @@ -193,10 +194,7 @@ function Standings.fetchMatch(entry)
return
end

local allMatchesFromBrackets = MatchGroupUtil.fetchMatches(bracketId)
return Array.filter(allMatchesFromBrackets, function(match)
return match.matchId == matchid
end)[1]
return MatchGroupUtil.fetchMatchGroup(bracketId).matchesById[matchid]
end

---@param standings StandingsModel
Expand Down
Loading