feat(Infobox): add Fortnite Power Rankings for players and organizations#7633
Open
Mehdi9120310391 wants to merge 35 commits into
Open
feat(Infobox): add Fortnite Power Rankings for players and organizations#7633Mehdi9120310391 wants to merge 35 commits into
Mehdi9120310391 wants to merge 35 commits into
Conversation
Collaborator
|
Note from hesketh2: I've mentioned this internally to our Community Team + Nydra and it's good to go from our end, the more cooler features specially community-driven the better : ) |
mbergen
requested changes
Jun 9, 2026
hjpalpha
requested changes
Jun 9, 2026
hjpalpha
left a comment
hjpalpha
left a comment
Collaborator
There was a problem hiding this comment.
infoboxes (especially infobox player) are already pretty long, does it have to be displayed in the infobox?
have you considered displaying it somewhere else on the page?
Co-authored-by: hjpalpha <75081997+hjpalpha@users.noreply.github.com>
Co-authored-by: hjpalpha <75081997+hjpalpha@users.noreply.github.com>
Contributor
Author
not really, for me it's the best option |
Co-authored-by: hjpalpha <75081997+hjpalpha@users.noreply.github.com>
Co-authored-by: hjpalpha <75081997+hjpalpha@users.noreply.github.com>
hjpalpha
reviewed
Jun 10, 2026
hjpalpha
left a comment
hjpalpha
left a comment
Collaborator
There was a problem hiding this comment.
review for Module:PowerRankings
(don't have the time to review the other one atm, will likely review it in the next days)
hjpalpha
reviewed
Jun 10, 2026
hjpalpha
left a comment
hjpalpha
left a comment
Collaborator
There was a problem hiding this comment.
skimmed through it on phone
ElectricalBoy
requested changes
Jun 11, 2026
hjpalpha
reviewed
Jun 16, 2026
Applying hjpalpha's code
hjpalpha
reviewed
Jun 18, 2026
hjpalpha
left a comment
hjpalpha
left a comment
Collaborator
There was a problem hiding this comment.
to make the limter happy (line length)
hjpalpha
reviewed
Jun 18, 2026
hjpalpha
reviewed
Jun 18, 2026
Collaborator
|
won't review this going forwards as i refactored a good chunk of this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We have implemented a "power ranking" system for the various organizations present on Fortnite, based on data such as the PR of the organization's players (using official data provided by Epic Games) who are in the top 200 best players in the world, as well as the organization's earnings for the year in question.
Rankings:
How did you test this change?
|dev=mej: