elbepack: cyclonedx-sbom: add support for flat repository layouts#463
Open
d4nuu8 wants to merge 2 commits into
Open
elbepack: cyclonedx-sbom: add support for flat repository layouts#463d4nuu8 wants to merge 2 commits into
d4nuu8 wants to merge 2 commits into
Conversation
t-8ch
reviewed
Jun 11, 2026
| # https://deb.corporate.com/kuka/dom/ethtool_6.14.2-1%7ekdeb13u1_arm64.deb | ||
| return '/'.join(uri_parts[:-1]) | ||
|
|
||
| raise ValueError('Unexpected URI format: too few parts') |
Contributor
There was a problem hiding this comment.
Could you reformat this to make it a bit easier to understand?
if < 6:
if endswith('.deb)
...
else
...
else if:
...
else if:
...
else:
...
This still won't handle all cases I guess and at some point we should figure out a better variant.
Contributor
Author
There was a problem hiding this comment.
I've added tests for the supported URLs and refactored it completely.
What do you think?
This patch adds tests for the already supported URLs. This enables us to easily refactor the current implementation and extend it for further URL formats. Signed-off-by: Daniel Braunwarth <daniel.braunwarth@kuka.com>
This brings support for repositories using a flat layout (e.g. minidinst). Signed-off-by: Daniel Braunwarth <daniel.braunwarth@kuka.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This brings support for repositories using a flat layout (e.g. minidinst).