Skip to content

Update cosmwasm std 2.0.3#48

Draft
ueco-jb wants to merge 1 commit into
mainfrom
update-cosmwasm-std-2-0-3-again
Draft

Update cosmwasm std 2.0.3#48
ueco-jb wants to merge 1 commit into
mainfrom
update-cosmwasm-std-2-0-3-again

Conversation

@ueco-jb

@ueco-jb ueco-jb commented Oct 14, 2024

Copy link
Copy Markdown
Member

While trying to run tests with the backtraces features enabled, I hit several issues:

  • on latest nightly there is some feature missing
error[E0635]: unknown feature `provide_any`
 --> /home/u/.cargo/registry/src/index.crates.io-6f17d22bba15001f/cosmwasm-std-1.5.8/src/lib.rs:2:45
  |
2 | #![cfg_attr(feature = "backtraces", feature(provide_any))]
  |                                             ^^^^^^^^^^^

For more information about this error, try `rustc --explain E0635`.
error: could not compile `cosmwasm-std` (lib) due to previous error
warning: build failed, waiting for other jobs to finish...
  • if I go back to the nightly from the currently used cosmwasm 1.5.7 for example November 2023
error[E0635]: unknown feature `provide_any`
 --> /home/u/.cargo/registry/src/index.crates.io-6f17d22bba15001f/cosmwasm-std-1.5.8/src/lib.rs:2:45
  |
2 | #![cfg_attr(feature = "backtraces", feature(provide_any))]
  |                                             ^^^^^^^^^^^

For more information about this error, try `rustc --explain E0635`.
error: could not compile `cosmwasm-std` (lib) due to previous error
warning: build failed, waiting for other jobs to finish...
  • I noticed that from the next version the feature was removed altogether and should work with regular RUST_BACKTRACE feature; hence my request to update, unless there is some opinion against it

@ueco-jb ueco-jb requested a review from ethanfrey October 14, 2024 09:57
@ueco-jb ueco-jb self-assigned this Oct 14, 2024
@ueco-jb

ueco-jb commented Oct 14, 2024

Copy link
Copy Markdown
Member Author

If we chose to continue with the update, some changes are required (for example in the interfaces).

@ethanfrey

Copy link
Copy Markdown
Contributor

Let's not update to 2.0.3 (which will be good) until we update layer-sdk to cosmwasm-2.0.
There is some cw-orch stuff I wanted to sort out first.

Keep this branch around for the upgrade, but we should not require it.

@ethanfrey

Copy link
Copy Markdown
Contributor

You mean RUST_BACKTRACE=1 cargo test?

I never heard of RUST_BACKTRACES (plural) flag.

@ueco-jb

ueco-jb commented Oct 14, 2024

Copy link
Copy Markdown
Member Author

https://github.com/CosmWasm/cosmwasm/blob/v2.0.3/CHANGELOG.md?plain=1#L129-L133

You mean RUST_BACKTRACE=1 cargo test?

Yeah that's what I meant.

@ethanfrey

Copy link
Copy Markdown
Contributor

Huh, looks like it needs +nightly and they fixed it in 1.2.2... CosmWasm/cosmwasm#1623

I guess we need to live without it now though. I will try to sort out 2.0 upgrade path sooner than later

@ismellike

Copy link
Copy Markdown
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants