Chore: Update to Node 24#658
Open
Ramy-Huffman-LPL wants to merge 6 commits into
Open
Conversation
Ramy-Huffman-LPL
commented
May 4, 2026
| steps: | ||
| - name: Check out latest code | ||
| uses: actions/checkout@v3 | ||
| uses: actions/checkout@v4 |
Author
There was a problem hiding this comment.
FYI - v3 runs on the deprecated Node 16. v4 runs on Node 20 instead.
Author
|
Closing PR to reopen and see if it will fix stuck state |
mwislek
approved these changes
May 27, 2026
Contributor
mwislek
left a comment
mwislek
left a comment
There was a problem hiding this comment.
🚀
All of the tests pass and the storybook runs properly. There are a lot of url.parse() deprecation warnings, as well as some SCSS warnings when the storybook is built. But that is work, likely, for a separate PR.
I wasn't sure that I could test the publish GH action, so assume you'll find out if that works when the new version is published.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #657
Author Checklist