Fix: resolve webhook retry processor conflict and share retry config (#8)#28
Open
Sam-Rytech wants to merge 1 commit into
Open
Fix: resolve webhook retry processor conflict and share retry config (#8)#28Sam-Rytech wants to merge 1 commit into
Sam-Rytech wants to merge 1 commit into
Conversation
- Removed webhookRetryScheduler.ts as its logic conflicts with webhookService.ts - Extracted backoff config and max attempts into a shared config WEBHOOK_RETRY_CONFIG - Updated WebhookService.processRetries query to properly alias columns to avoid ambiguous references and to utilize the new config - Updated index.ts to wire up the surviving webhookRetryProcessor - Added test verifying retry processor respects backoff delays and max attempts Closes #123
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves the conflicting retry implementations between
webhookRetrySchedulerandwebhookService.Changes Made
webhookRetryProcessor.tsas the single surviving implementation and wired it intoindex.ts.webhookRetryScheduler.tsto remove duplicate sources of truth.WEBHOOK_RETRY_CONFIGused bywebhookService.ts.wd.id,ws.callback_url, etc.), avoiding ambiguous references and mapping correctly to the current schema.webhookRetryProcessor.test.tsasserting that the processor respects the configured backoff delays and max attempts.Closes #8