Skip to content

fix(ci): point Dependabot npm at the workspace root only#772

Open
ogazboiz wants to merge 1 commit into
mainfrom
fix/dependabot-workspace-lockfile
Open

fix(ci): point Dependabot npm at the workspace root only#772
ogazboiz wants to merge 1 commit into
mainfrom
fix/dependabot-workspace-lockfile

Conversation

@ogazboiz

Copy link
Copy Markdown
Contributor

Why

flowfi is a single npm workspace (frontend + backend hoisted into one root package-lock.json). dependabot.yml declared separate npm ecosystems for /frontend and /backend, but those entries only bump the directory's package.json without updating the root lockfile that CI runs npm ci against.

Result: every Dependabot PR from those two entries dies at install:

npm error `npm ci` can only install packages when your package.json and package-lock.json ... are in sync
npm error Invalid: lock file's next@16.2.7 does not satisfy next@16.2.9

That is exactly why PRs #764-#770 are all red on Backend CI / Frontend CI / Backend npm test / Vuln Scan, while the grouped root PR (#771) passed and merged cleanly.

Fix

Drop the redundant /frontend and /backend npm entries. The root / npm entry already covers the whole workspace and updates the root lockfile, so future Dependabot PRs will install cleanly. Cargo and github-actions entries are unchanged.

Follow-up (separate)

The currently-open PRs #764-#770 were generated by the now-removed entries and cannot pass as-is; they should be closed (Dependabot will re-propose the relevant bumps from the root entry on the next run). #763 (soroban-sdk 22 -> 26) is a real major Rust bump that needs a contracts migration, not a lockfile fix.

flowfi is a single npm workspace (frontend + backend hoisted into one root
package-lock.json). dependabot.yml declared separate npm ecosystems for
/frontend and /backend, but those only bump the directory's package.json
without updating the root lockfile that CI runs `npm ci` against. Every PR they
opened therefore died at install with:

  npm error `npm ci` can only install packages when your package.json and
  package-lock.json ... are in sync
  npm error Invalid: lock file's next@16.2.7 does not satisfy next@16.2.9

The root "/" npm entry already covers the whole workspace and updates the root
lockfile (those PRs, e.g. the grouped minor-and-patch one, pass CI). Drop the
two per-directory npm entries so future Dependabot PRs install cleanly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant