Prefer Class-File API on Java 24 or above#477
Open
Goooler wants to merge 12 commits into
Open
Conversation
Owner
|
While I generally want this, I think we don't win much with it. Only annoying any users we have that are running older than JDK 24. No one should be running old JDKs, but as we know most people generally do. Maybe once AGP requires JDK 24 (or newer) this will be less hostile of a change. |
Contributor
Author
|
Reasonable. Alternatively, there could be two impls for Java 24 newer or not (Multi-Release JAR?). |
Goooler
changed the title
Goooler
commented
Mar 11, 2026
# Conflicts: # CHANGELOG.md
# Conflicts: # formats/api/formats.api # formats/src/main/kotlin/com/jakewharton/diffuse/format/Class.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #474.