tombstone-e2e: use POSIX shell for portability#347
Closed
kev009 wants to merge 1 commit into
Closed
Conversation
The test relied on GNU-style options unavailable on AIX and Solaris
native tools: grep -F, sed -i, and a \t escape in a sed character class
Replace them with POSIX-only helpers so the test runs
without requiring GNU tools or innshellvars detection:
- contains(): a while-read/case substring matcher (no grep -F)
- countlines(): wc -l | tr -cd '0-9' (no sed, handles AIX wc
leading whitespace)
- setconf(): sed > tmp && mv (no sed -i)
Fixes InterNetNews#345.
Contributor
|
Many thanks for having taken the time to look at this and improve the portability. |
Julien-Elie
added
bug
Julien-Elie
pushed a commit
that referenced
this pull request
Jun 19, 2026
The test relied on GNU-style options unavailable on AIX and Solaris
native tools: grep -F, sed -i, and a \t escape in a sed character
class.
Replace them with POSIX-only helpers so the test runs
without requiring GNU tools or innshellvars detection:
- contains(): a while-read/case substring matcher (no grep -F)
- countlines(): wc -l | tr -cd '0-9' (no sed, handles AIX wc
leading whitespace)
- setconf(): sed > tmp && mv (no sed -i)
Fixes #345.
Closes #347.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test relied on GNU-style options unavailable on AIX and Solaris native tools: grep -F, sed -i, and a \t escape in a sed character class
Replace them with POSIX-only helpers so the test runs without requiring GNU tools or innshellvars detection:
Fixes #345.